RSDK-12187: Store reload versions at the module and part level #5365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
gmulz
approved these changes
Oct 13, 2025
abe-winter
approved these changes
Oct 13, 2025
| const reloadVersion = "reload" | ||
| const ( | ||
| reloadVersionPrefix = "reload" | ||
| reloadSourceVersionPrefix = "reload-source" |
There was a problem hiding this comment.
what's the difference between these two? one is the source tarball that gets fed into cloud build, the other is the binary artifact that is produced?
There was a problem hiding this comment.
Yup that is the difference.
stuqdog
approved these changes
Oct 13, 2025
I did a lot of testing myself so I'm confident in this change. @Ethan I think lets do some testing together later in the week. Or I can handle it. After both our changes are merged in. And probably with the reload progress spinner changes if I have that merged in time. This way we can make sure everything in main across all projects works together. |
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how reload versions are stored and incorporates @gmulz's idea of making hot reloading storage at the part level to avoid issues if two developers hot reload the same module on different parts:
Testing
Did full round of testing to ensure the workflow passed in a preview environment along with app changes. Verified in our DB that it contained both versions while after the build finished, and then once the copy to part finished, that the source code was deleted.